WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179642
ServiceWorker Inspector: Frontend changes to support Network tab and sub resources
https://bugs.webkit.org/show_bug.cgi?id=179642
Summary
ServiceWorker Inspector: Frontend changes to support Network tab and sub reso...
Joseph Pecoraro
Reported
2017-11-13 15:36:34 PST
ServiceWorker Inspector: Frontend changes to support Network tab and sub resources Network Tab: - Should show requests made by the ServiceWorker Resource Tab: (UI like a Dedicated Worker) - Should show sub-resources loaded by the ServiceWorker - Should categorize the sub-resources underneath the ServiceWorker component
Attachments
[PATCH] Proposed Fix
(27.21 KB, patch)
2017-11-17 15:49 PST
,
Joseph Pecoraro
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
[IMAGE] Resources Tab
(163.53 KB, image/png)
2017-11-17 15:50 PST
,
Joseph Pecoraro
no flags
Details
[IMAGE] Network Tab - Table
(98.38 KB, image/png)
2017-11-17 15:51 PST
,
Joseph Pecoraro
no flags
Details
[IMAGE] Network Tab - Detail
(130.08 KB, image/png)
2017-11-17 15:51 PST
,
Joseph Pecoraro
no flags
Details
Archive of layout-test-results from ews100 for mac-elcapitan
(2.56 MB, application/zip)
2017-11-17 16:43 PST
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews114 for mac-elcapitan
(3.52 MB, application/zip)
2017-11-17 17:24 PST
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
(3.79 MB, application/zip)
2017-11-17 17:43 PST
,
EWS Watchlist
no flags
Details
[PATCH] Proposed Fix
(30.71 KB, patch)
2017-11-27 16:49 PST
,
Joseph Pecoraro
bburg
: review+
bburg
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-11-13 15:36:53 PST
<
rdar://problem/35517704
>
Joseph Pecoraro
Comment 2
2017-11-17 15:49:37 PST
Created
attachment 327258
[details]
[PATCH] Proposed Fix There are a few things I want to address in follow-ups: 1. Image resources added via CacheStorage.prototype.add / fetch() don't show up properly - this is essentially pre-existing bad behavior for fetching any binary content 2. Metrics data is not included - this requires enabling ResourceTiming in ServiceWorkers, which I'll be looking into
Joseph Pecoraro
Comment 3
2017-11-17 15:50:40 PST
Created
attachment 327259
[details]
[IMAGE] Resources Tab
Joseph Pecoraro
Comment 4
2017-11-17 15:51:03 PST
Created
attachment 327260
[details]
[IMAGE] Network Tab - Table
Joseph Pecoraro
Comment 5
2017-11-17 15:51:23 PST
Created
attachment 327261
[details]
[IMAGE] Network Tab - Detail
Joseph Pecoraro
Comment 6
2017-11-17 15:52:00 PST
Note that the ResponseSource is an emdash right now, that is related to the other metrics that will be enabled with ResourceTiming.
EWS Watchlist
Comment 7
2017-11-17 16:43:39 PST
Comment hidden (obsolete)
Comment on
attachment 327258
[details]
[PATCH] Proposed Fix
Attachment 327258
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/5282736
New failing tests: http/tests/inspector/network/resource-metrics.html http/tests/inspector/network/fetch-response-body.html http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html http/tests/inspector/network/resource-timing.html http/tests/inspector/network/resource-response-source-network.html http/tests/inspector/network/fetch-network-data.html inspector/worker/resources-in-worker.html inspector/network/xhr-json-blob-has-content.html http/tests/inspector/network/resource-response-source-memory-cache.html http/tests/inspector/network/xhr-request-data-encoded-correctly.html inspector/dom-debugger/xhr-breakpoints.html http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html http/tests/inspector/network/copy-as-curl.html inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html http/tests/inspector/network/xhr-response-body.html inspector/unit-tests/target-manager.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html http/tests/inspector/network/resource-mime-type.html inspector/model/script-resource-relationship.html
EWS Watchlist
Comment 8
2017-11-17 16:43:40 PST
Comment hidden (obsolete)
Created
attachment 327274
[details]
Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
EWS Watchlist
Comment 9
2017-11-17 17:24:49 PST
Comment hidden (obsolete)
Comment on
attachment 327258
[details]
[PATCH] Proposed Fix
Attachment 327258
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/5283058
New failing tests: http/tests/inspector/network/resource-metrics.html inspector/unit-tests/target-manager.html http/tests/inspector/network/fetch-response-body.html http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html http/tests/inspector/network/resource-timing.html http/tests/inspector/network/resource-response-source-network.html http/tests/inspector/network/fetch-network-data.html http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html inspector/model/script-resource-relationship.html http/tests/inspector/network/xhr-request-data-encoded-correctly.html http/tests/inspector/network/copy-as-curl.html inspector/network/xhr-json-blob-has-content.html http/tests/inspector/network/resource-mime-type.html http/tests/inspector/network/xhr-response-body.html http/tests/inspector/network/resource-response-source-memory-cache.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html inspector/dom-debugger/xhr-breakpoints.html
EWS Watchlist
Comment 10
2017-11-17 17:24:50 PST
Comment hidden (obsolete)
Created
attachment 327282
[details]
Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
EWS Watchlist
Comment 11
2017-11-17 17:43:16 PST
Comment hidden (obsolete)
Comment on
attachment 327258
[details]
[PATCH] Proposed Fix
Attachment 327258
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/5283949
New failing tests: http/tests/inspector/network/resource-metrics.html http/tests/inspector/network/resource-response-service-worker.html http/tests/inspector/network/fetch-response-body.html http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html inspector/unit-tests/target-manager.html http/tests/inspector/network/resource-mime-type.html http/tests/inspector/network/resource-sizes-disk-cache.html http/tests/inspector/network/resource-timing.html http/tests/inspector/network/resource-response-source-memory-cache.html http/tests/inspector/network/copy-as-curl.html http/tests/inspector/network/xhr-response-body.html http/tests/inspector/network/resource-response-source-network.html inspector/worker/resources-in-worker.html inspector/network/xhr-json-blob-has-content.html inspector/model/script-resource-relationship.html http/tests/inspector/network/xhr-request-data-encoded-correctly.html inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html http/tests/inspector/network/fetch-network-data.html http/tests/inspector/network/resource-response-source-disk-cache.html http/tests/inspector/network/resource-sizes-network.html inspector/dom-debugger/xhr-breakpoints.html
EWS Watchlist
Comment 12
2017-11-17 17:43:18 PST
Comment hidden (obsolete)
Created
attachment 327287
[details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Joseph Pecoraro
Comment 13
2017-11-27 16:49:57 PST
Created
attachment 327713
[details]
[PATCH] Proposed Fix I was missing `WI.pageTarget` in Test.js
Blaze Burg
Comment 14
2017-11-28 12:58:15 PST
Comment on
attachment 327713
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=327713&action=review
r=me
> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:522 > + if (type === "Document" && frame.mainResource.url === url && frame.loaderIdentifier === loaderIdentifier)
I'd prefer we move the enum somewhere else, rather than rely on bare string literals. Could it go on NetworkAgent? This can be a followup if it gets messy.
> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:524 > + else if (type === "Document" && frame.provisionalMainResource && frame.provisionalMainResource.url === url && frame.provisionalLoaderIdentifier === loaderIdentifier)
Ditto.
> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:710 > + if (resourcePayload.type === "Document" && resourcePayload.url === payload.frame.url)
Ditto.
> Source/WebInspectorUI/UserInterface/Models/Resource.js:98 > + static preferredType(type, mimeType)
This name is somewhat vague.
> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:275 > +InspectorBackend.MainConnection = class InspectorBackendMainConnection extends InspectorBackend.Connection
OK
> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:876 > + let populateTargetResources = (target) => {
Nit: I would use Cocoa style naming, populateResourcesForFrame() populateResourcesForTarget()
Joseph Pecoraro
Comment 15
2017-11-28 15:37:09 PST
Comment on
attachment 327713
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=327713&action=review
>> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:522 >> + if (type === "Document" && frame.mainResource.url === url && frame.loaderIdentifier === loaderIdentifier) > > I'd prefer we move the enum somewhere else, rather than rely on bare string literals. Could it go on NetworkAgent? This can be a followup if it gets messy.
Yeah, we will want to move this to Network eventually. At this point Network should be considered the base and Page / ServiceWorker are disjoint and both would have a Network component.
>> Source/WebInspectorUI/UserInterface/Models/Resource.js:98 >> + static preferredType(type, mimeType) > > This name is somewhat vague.
Hmm, would bestType() or mostSpecificType() be better? This is something I'm going to be circling back to as I try to make an XHR/Fetch of an Image resource show properly.
>> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:876 >> + let populateTargetResources = (target) => { > > Nit: I would use Cocoa style naming, populateResourcesForFrame() populateResourcesForTarget()
I like that suggestion.
Joseph Pecoraro
Comment 16
2017-11-28 15:45:54 PST
<
https://trac.webkit.org/r225244
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug