Bug 179641 - FetchResponse should keep unfiltered ResourceResponse so that it can be used in Service Worker
Summary: FetchResponse should keep unfiltered ResourceResponse so that it can be used ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-13 15:35 PST by youenn fablet
Modified: 2020-02-13 14:06 PST (History)
11 users (show)

See Also:


Attachments
Patch (10.07 KB, patch)
2017-11-13 16:08 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (25.53 KB, patch)
2017-11-17 13:18 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (24.07 KB, patch)
2017-11-17 13:35 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.52 MB, application/zip)
2017-11-17 14:40 PST, EWS Watchlist
no flags Details
Patch (28.45 KB, patch)
2017-12-07 17:00 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (29.40 KB, patch)
2017-12-07 18:01 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.89 MB, application/zip)
2017-12-07 19:36 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-13 15:35:08 PST
Currently a fetch response filters its ResourceResponse.
Comment 1 youenn fablet 2017-11-13 16:08:01 PST
Created attachment 326819 [details]
Patch
Comment 2 youenn fablet 2017-11-17 13:18:27 PST
Created attachment 327221 [details]
Patch
Comment 3 youenn fablet 2017-11-17 13:35:02 PST
Created attachment 327226 [details]
Patch
Comment 4 EWS Watchlist 2017-11-17 14:40:27 PST
Comment on attachment 327226 [details]
Patch

Attachment 327226 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5280639

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-frame-resource.https.html
Comment 5 EWS Watchlist 2017-11-17 14:40:29 PST
Created attachment 327242 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Radar WebKit Bug Importer 2017-12-07 16:52:25 PST
<rdar://problem/35923570>
Comment 7 youenn fablet 2017-12-07 17:00:39 PST
Created attachment 328757 [details]
Patch
Comment 8 youenn fablet 2017-12-07 18:01:51 PST
Created attachment 328767 [details]
Patch
Comment 9 EWS Watchlist 2017-12-07 19:36:21 PST
Comment on attachment 328767 [details]
Patch

Attachment 328767 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5537882

New failing tests:
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html
Comment 10 EWS Watchlist 2017-12-07 19:36:22 PST
Created attachment 328781 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 youenn fablet 2017-12-08 09:35:07 PST
(In reply to Build Bot from comment #9)
> Comment on attachment 328767 [details]
> Patch
> 
> Attachment 328767 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5537882
> 
> New failing tests:
> imported/w3c/web-platform-tests/html/webappapis/scripting/events/
> messageevent-constructor.https.html

Crash is unrelated to this patch (see https://bugs.webkit.org/show_bug.cgi?id=180518).
Comment 12 WebKit Commit Bot 2017-12-08 14:41:52 PST
Comment on attachment 328767 [details]
Patch

Clearing flags on attachment: 328767

Committed r225702: <https://trac.webkit.org/changeset/225702>
Comment 13 WebKit Commit Bot 2017-12-08 14:41:54 PST
All reviewed patches have been landed.  Closing bug.