RESOLVED FIXED 179637
[Windows] Fix error while launching subprocess on Windows Python 
https://bugs.webkit.org/show_bug.cgi?id=179637
Summary [Windows] Fix error while launching subprocess on Windows Python
Basuke Suzuki
Reported 2017-11-13 15:01:03 PST
When python try to launch sub process on Windows, the environment variables passing as unicode causes this error: > TypeError: environment can only contain strings
Attachments
fix (1.50 KB, patch)
2017-11-13 15:27 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix test-webkitpy failure (1.54 KB, patch)
2017-11-13 17:56 PST, Basuke Suzuki 		achristensen: review-
DetailsFormatted DiffDiff
fixed (3.79 KB, patch)
2017-11-14 16:10 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix for test-webkitpy (9.09 KB, patch)
2017-11-14 16:26 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix conflict (9.07 KB, patch)
2017-11-14 16:40 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix CRLF (4.43 KB, patch)
2017-11-14 16:42 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
remove (4.01 KB, patch)
2017-11-14 16:47 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-11-13 15:27:15 PST
Created attachment 326814 [details] fix Convert environment variables from unicode to str. This is required for Python 2 on Windows.
Basuke Suzuki
Comment 2 2017-11-13 17:56:16 PST
Created attachment 326835 [details] fix test-webkitpy failure
Per Arne Vollan
Comment 3 2017-11-13 18:16:46 PST
Comment on attachment 326835 [details] fix test-webkitpy failure View in context: https://bugs.webkit.org/attachment.cgi?id=326835&action=review > Tools/ChangeLog:6 > + [Windows] Fix error while launching subprocess on Windows Python > + https://bugs.webkit.org/show_bug.cgi?id=179637 > + > + Reviewed by NOBODY (OOPS!). Perhaps you could add an explanation of the problem and the fix in the Changelog? > Tools/Scripts/webkitpy/port/server_process.py:69 > + if env is not None and self._port.host.platform.is_win() and not self._port.host.platform.is_cygwin(): Does the expression 'env is not None' have a more compact form? I think we also should consider adding a 'platform.is_native_win()' function.
Alex Christensen
Comment 4 2017-11-14 13:54:27 PST
Comment on attachment 326835 [details] fix test-webkitpy failure I agree, I think this should be better organized.
Basuke Suzuki
Comment 5 2017-11-14 16:10:24 PST
Created attachment 326934 [details] fixed fixed as commented
Basuke Suzuki
Comment 6 2017-11-14 16:26:03 PST
Created attachment 326939 [details] fix for test-webkitpy
Basuke Suzuki
Comment 7 2017-11-14 16:40:07 PST
Created attachment 326943 [details] fix conflict
Basuke Suzuki
Comment 8 2017-11-14 16:42:10 PST
Created attachment 326944 [details] fix CRLF
Basuke Suzuki
Comment 9 2017-11-14 16:47:14 PST
Created attachment 326946 [details] remove
WebKit Commit Bot
Comment 10 2017-11-14 19:46:16 PST
Comment on attachment 326946 [details] remove Clearing flags on attachment: 326946 Committed r224866: <https://trac.webkit.org/changeset/224866>
WebKit Commit Bot
Comment 11 2017-11-14 19:46:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-11-15 09:32:22 PST
<rdar://problem/35561889>
Note You need to log in before you can comment on or make changes to this bug.