Bug 179630 - [GTK] Require woff2 1.0.2 and drop direct brotli dependency
Summary: [GTK] Require woff2 1.0.2 and drop direct brotli dependency
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2017-11-13 13:23 PST by Michael Catanzaro
Modified: 2017-11-19 17:45 PST (History)
5 users (show)

See Also:

Patch (4.72 KB, patch)
2017-11-13 13:25 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-11-13 13:23:03 PST
The initial releases of the woff2 library have a bug with the pkg-config file: they do not directly pull in brotli. We have worked around this thus far by requiring it manually, but this should not be needed. Tom fixed it with https://github.com/google/woff2/commit/aff949b84713590907b259ecb49f630a19df55c0. A new version is now available with this fix, which we should use.
Comment 1 Michael Catanzaro 2017-11-13 13:25:55 PST
Created attachment 326791 [details]
Comment 2 WebKit Commit Bot 2017-11-13 16:42:23 PST
Comment on attachment 326791 [details]

Clearing flags on attachment: 326791

Committed r224793: <https://trac.webkit.org/changeset/224793>
Comment 3 WebKit Commit Bot 2017-11-13 16:42:25 PST
All reviewed patches have been landed.  Closing bug.