Bug 179628 - Occasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
Summary: Occasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-13 13:09 PST by Tim Horton
Modified: 2017-11-22 14:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2017-11-13 13:09 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-11-13 13:09:04 PST 
Occasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
Comment 1 Tim Horton 2017-11-13 13:09:32 PST 
Created attachment 326785 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-13 14:22:32 PST 
Comment on attachment 326785 [details]
Patch

Clearing flags on attachment: 326785

Committed r224781: <https://trac.webkit.org/changeset/224781>
Comment 3 WebKit Commit Bot 2017-11-13 14:22:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-11-15 09:33:10 PST 
<rdar://problem/35561920>
Comment 5 Garvan Keeley 2017-11-22 12:38:37 PST 
Just mentioning for your consideration that our app's crash reports for this mention a NaN in CGSize (in UIScrollView setBounds), hopefully the added CGRectIsNull() check higher in the call stack is preventing the NaN.
Comment 6 Tim Horton 2017-11-22 14:20:03 PST 
(In reply to Garvan Keeley from comment #5)
> Just mentioning for your consideration that our app's crash reports for this
> mention a NaN in CGSize (in UIScrollView setBounds), hopefully the added
> CGRectIsNull() check higher in the call stack is preventing the NaN.

That’s the plan, anyway!