This helps avoid false positives due to abuse of this test function when doing crashes. <rdar://problem/35492518>
Created attachment 326776 [details] proposed patch.
Comment on attachment 326776 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=326776&action=review > Source/JavaScriptCore/jsc.cpp:3030 > + if (UNLIKELY(exec->argumentCount() < 1)) { > + throwTypeError(exec, scope, ASCIILiteral("Invalid use of loadGetterFromGetterSetter test function: missing argument")); > + return encodedJSValue(); > + } This is unneeded unless you really care about the error message. This will fall out of the check below.
Comment on attachment 326776 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=326776&action=review Thanks for the review. >> Source/JavaScriptCore/jsc.cpp:3030 >> + } > > This is unneeded unless you really care about the error message. This will fall out of the check below. I will remove this.
Landed in r224770: <http://trac.webkit.org/r224770>.