Bug 179617 - std::expected: fix and test move
Summary: std::expected: fix and test move
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-13 10:42 PST by JF Bastien
Modified: 2017-11-15 09:33 PST (History)
10 users (show)

See Also:


Attachments
patch (7.24 KB, patch)
2017-11-13 10:44 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-11-13 10:42:12 PST
Move doesn't seem quite right everywhere.
Comment 1 JF Bastien 2017-11-13 10:44:33 PST
Created attachment 326771 [details]
patch
Comment 2 Build Bot 2017-11-13 10:46:47 PST
Attachment 326771 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:428:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-11-13 11:19:33 PST
Comment on attachment 326771 [details]
patch

Clearing flags on attachment: 326771

Committed r224762: <https://trac.webkit.org/changeset/224762>
Comment 4 WebKit Commit Bot 2017-11-13 11:19:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 09:33:21 PST
<rdar://problem/35561940>