Bug 179616 – REGRESSION(r224658): check-webkit-style cannot construct valid iOS version without an iOS SDK

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

After <https://trac.webkit.org/changeset/224658>, when running check-webkit-style on a Mac without an iOS SDK, an exception is thrown.

This is quite related to <https://bugs.webkit.org/show_bug.cgi?id=179534>, but the fix for this problem is much smaller and a subset of the fixed for the larger issue.

[Radar WebKit Bug Importer]

<rdar://problem/35507018>

[Jonathan Bedard]

Created attachment 326769 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 326769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review

> Tools/ChangeLog:10
> +        Instead of throwing an exception when we ask for an unavailable SDK on Mac,
> +        we should return None.

But the problem is related to iOS SDKs, not mac.

[Jonathan Bedard]

Comment on attachment 326769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review

>> Tools/ChangeLog:10
>> +        we should return None.
> 
> But the problem is related to iOS SDKs, not mac.

It only happens on Mac when we ask for an SDK (which could be iOS, watchOS or tvOS, in our case, it's iOS that's causing the problem) which is unavailable.

This change has implications beyond just the iOS SDK, although at the moment, that is the only SDK that uses this codepath.

[David Kilzer (:ddkilzer)]

Comment on attachment 326769 [details]
Patch

r=me

Please check the Win EWS (it's orange) before landing.

[Jonathan Bedard]

(In reply to David Kilzer (:ddkilzer) from comment #5)
> Comment on attachment 326769 [details]
> Patch
> 
> r=me
> 
> Please check the Win EWS (it's orange) before landing.

It was test failures for mac and a borked SVN for Windows, everything is green now.

[WebKit Commit Bot]

Comment on attachment 326769 [details]
Patch

Clearing flags on attachment: 326769

Committed r224765: <https://trac.webkit.org/changeset/224765>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.