Bug 179610 - [Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
Summary: [Cairo] Move state change operations from GraphicsContextCairo to CairoOperat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-13 03:33 PST by Zan Dobersek
Modified: 2018-11-07 03:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (16.73 KB, patch)
2017-11-13 03:36 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (16.75 KB, patch)
2017-11-13 05:41 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-11-13 03:33:15 PST 
[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
Comment 1 Zan Dobersek 2017-11-13 03:36:39 PST 
Created attachment 326754 [details]
Patch
Comment 2 Zan Dobersek 2017-11-13 05:41:10 PST 
Created attachment 326757 [details]
Patch for landing
Comment 3 Zan Dobersek 2017-11-13 05:41:43 PST 
Comment on attachment 326757 [details]
Patch for landing

Clearing flags on attachment: 326757

Committed r224753: <https://trac.webkit.org/changeset/224753>
Comment 4 Zan Dobersek 2017-11-13 05:41:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 09:44:23 PST 
<rdar://problem/35562337>
Comment 6 Frédéric Wang (:fredw) 2018-11-07 03:27:57 PST 
Comment on attachment 326757 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=326757&action=review

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:204
> +    return Cairo::State::getCTM(*platformContext());

All these Cairo::State::* calls required CairoOperations.h. I'll land a fix to add the missing include.
Comment 7 Frédéric Wang (:fredw) 2018-11-07 03:29:36 PST 
Committed r237920: <https://trac.webkit.org/changeset/237920>