Bug 179607 - Several XHR and CORS tests are flaky due to inconsistent order of console messages
Summary: Several XHR and CORS tests are flaky due to inconsistent order of console mes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 179608 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-13 02:24 PST by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2020-06-29 07:31 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.46 KB, patch)
2019-11-12 18:33 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-13 02:24:56 PST
... but only due to inconsistency in console logs:

-CONSOLE MESSAGE: Cannot use wildcard in Access-Control-Allow-Origin when credentials flag is true.
-CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8800/XMLHttpRequest/resources/access-control-basic-allow-star.py due to access control checks.
 CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
 CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8800/XMLHttpRequest/resources/access-control-basic-allow.py due to access control checks.
 CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
 CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8800/XMLHttpRequest/resources/access-control-basic-allow-no-credentials.py due to access control checks.
+CONSOLE MESSAGE: Cannot use wildcard in Access-Control-Allow-Origin when credentials flag is true.
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8800/XMLHttpRequest/resources/access-control-basic-allow-star.py due to access control checks.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-15 08:38:34 PST
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/basic.htm [ Pass Failure ]
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/preflight-failure.htm [ Pass Failure ]
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/redirect-origin.htm [ Pass Failure ]
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/redirect-preflight.htm [ Pass Failure ]
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/status-preflight.htm [ Pass Failure ]
webkit.org/b/179607 imported/w3c/web-platform-tests/cors/status-async.htm [ Pass Failure ]
Comment 2 Brendan McLoughlin 2018-06-13 15:00:32 PDT
I've opened a pull request on the web-platform-test repo to fix the inconsistent ordering of console messages. https://github.com/web-platform-tests/wpt/pull/11489/

Once this lands in WPT and is imported into webkit we should be able to remove the expectations for the following tests.

imported/w3c/web-platform-tests/cors/basic.htm
imported/w3c/web-platform-tests/cors/preflight-failure.htm
imported/w3c/web-platform-tests/cors/status-async.htm
imported/w3c/web-platform-tests/cors/status-preflight.htm
imported/w3c/web-platform-tests/xhr/access-control-and-redirects-async-same-origin.htm
imported/w3c/web-platform-tests/xhr/access-control-and-redirects-async.htm

The remaining tests mentioned in this issue will still be failing because they contain unique output in their console messages.
Comment 3 youenn fablet 2019-11-12 18:32:23 PST
*** Bug 179608 has been marked as a duplicate of this bug. ***
Comment 4 youenn fablet 2019-11-12 18:33:48 PST
Created attachment 383418 [details]
Patch
Comment 5 WebKit Commit Bot 2019-11-13 13:31:34 PST
Comment on attachment 383418 [details]
Patch

Clearing flags on attachment: 383418

Committed r252427: <https://trac.webkit.org/changeset/252427>
Comment 6 WebKit Commit Bot 2019-11-13 13:31:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-13 13:32:16 PST
<rdar://problem/57165642>
Comment 8 Karl Rackler 2020-06-29 07:31:47 PDT
imported/w3c/web-platform-tests/cors/preflight-failure.htm and imported/w3c/web-platform-tests/cors/status-async.htm are no longer failing - remove expectations

Current history is green: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcors%2Fremote-origin.htm&test=imported%2Fw3c%2Fweb-platform-tests%2Fcors%2Fstatus-async.htm

These test was isolated from the others in the group as ones that are unexpectedly passing.