RESOLVED FIXED 179601
Some service worker tests are flaky due to console log messages 
https://bugs.webkit.org/show_bug.cgi?id=179601
Summary Some service worker tests are flaky due to console log messages
youenn fablet
Reported 2017-11-12 22:14:39 PST
We should remove these messages to get the tests stable using DumpJSConsoleLogInStdErr
Attachments
Patch (16.59 KB, patch)
2017-11-12 22:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.68 KB, patch)
2017-11-15 09:19 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-11-12 22:17:09 PST
Created attachment 326744 [details] Patch
Chris Dumez
Comment 2 2017-11-13 06:58:44 PST
Comment on attachment 326744 [details] Patch Then can we drop the Pass Failure?
youenn fablet
Comment 3 2017-11-13 07:16:27 PST
(In reply to Chris Dumez from comment #2) > Comment on attachment 326744 [details] > Patch > > Then can we drop the Pass Failure? That is the plan once the tests show to be stable on bots.
Chris Dumez
Comment 4 2017-11-13 08:02:03 PST
I think we should unskip them in this patch since we believe this addresses the flakiness. We can always skip them again if they turn out to be flaky still.
Alex Christensen
Comment 5 2017-11-13 15:57:56 PST
Comment on attachment 326744 [details] Patch I agree. Let's just mark them as passing.
youenn fablet
Comment 6 2017-11-15 09:16:26 PST
fetch-canvas-tainting.https.html and fetch-canvas-tainting-cache.https.html are consistently returning a FAIL result. But the reason for failure is sometimes changing, I will keep it as flaky in expectations. The other test seems more stable, I will update its expectation.
youenn fablet
Comment 7 2017-11-15 09:19:43 PST
Created attachment 326989 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-11-15 11:40:50 PST
Comment on attachment 326989 [details] Patch for landing Clearing flags on attachment: 326989 Committed r224891: <https://trac.webkit.org/changeset/224891>
WebKit Commit Bot
Comment 9 2017-11-15 11:40:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-11-15 12:06:50 PST
<rdar://problem/35566959>
youenn fablet
Comment 11 2017-11-16 09:02:40 PST
> The other test seems more stable, I will update its expectation. As per https://bugs.webkit.org/show_bug.cgi?id=179771, it is also flaky, I'll update it s expectation back to flaky...
Note You need to log in before you can comment on or make changes to this bug.