Bug 179585 – Web Inspector: Styles Redesign: clicking on the white space after the property sometimes places a blank property at the wrong index

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 326702 [details]
[Animated GIF] Bug

Clicking on a property with index=N should add a blank property at N+1.
Instead, it sometimes adds it at N+2.

[Radar WebKit Bug Importer]

<rdar://problem/35490780>

[Nikita Vasilyev]

Created attachment 331359 [details]
[Animated GIF] Indices don't get updated

I added this CSS for debugging:

.spreadsheet-style-declaration-editor .property[data-property-index]::before {
    content: attr(data-property-index)': ';
    color: red;
}

On the attached animated GIF you can see that the indices don't get updated after a blank property is discarded.

[Nikita Vasilyev]

Created attachment 331362 [details]
Patch

[Nikita Vasilyev]

Created attachment 331363 [details]
[Animated GIF] With patch applied

With patch applied and the debug CSS added.

[Joseph Pecoraro]

Comment on attachment 331362 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 331362 [details]
Patch

Clearing flags on attachment: 331362

Committed r226994: <https://trac.webkit.org/changeset/226994>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.