Bug 179584 - Web Inspector: Add CheckboxNavigationItem
Summary: Web Inspector: Add CheckboxNavigationItem
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
Keywords: InRadar
Depends on:
Reported: 2017-11-11 15:14 PST by Matt Baker
Modified: 2017-11-13 11:57 PST (History)
4 users (show)

See Also:

[Image] Shown in rendering frames view toolbar (94.30 KB, image/png)
2017-11-11 15:18 PST, Matt Baker
no flags Details
Patch (10.98 KB, patch)
2017-11-11 15:25 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-11-11 15:14:11 PST
This will be useful for creating local setting checkboxes in toolbars.
Comment 1 Radar WebKit Bug Importer 2017-11-11 15:15:59 PST
Comment 2 Matt Baker 2017-11-11 15:18:38 PST
Created attachment 326698 [details]
[Image] Shown in rendering frames view toolbar

Added to a GroupNavigationItem, to prevent dividers from being added between every checkbox item.

Will check item/label spacing against native apps.
Comment 3 Matt Baker 2017-11-11 15:25:46 PST
Created attachment 326699 [details]
Comment 4 BJ Burg 2017-11-13 11:51:34 PST
Comment on attachment 326699 [details]

Comment 5 WebKit Commit Bot 2017-11-13 11:57:20 PST
Comment on attachment 326699 [details]

Clearing flags on attachment: 326699

Committed r224766: <https://trac.webkit.org/changeset/224766>
Comment 6 WebKit Commit Bot 2017-11-13 11:57:21 PST
All reviewed patches have been landed.  Closing bug.