Bug 179582 - Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
Summary: Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks: 179303
  Show dependency treegraph
 
Reported: 2017-11-11 11:29 PST by Maciej Stachowiak
Modified: 2017-11-18 19:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (115.91 KB, patch)
2017-11-17 23:39 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2017-11-11 11:29:57 PST
The following encodings that are currently Mac-only and implemented with TEC, but are also known (by the same name) to ICU:

cp950
cp737
EUC-TW

The following are known to ICU by other names:
ISO-2022-JP-3: JIS7
JIS_C6226-1978: ibm-942_P12A-1999

The remaining TEC encodings are unknown to ICU by any name, as far as I can tell.
Comment 1 Maciej Stachowiak 2017-11-12 13:17:14 PST
This might also be an alternate ICU name:


Shift_JIS_X0213-2000: ibm-1399_P110-2003
Comment 2 Maciej Stachowiak 2017-11-12 14:27:49 PST
New proposed plan, which I'm verifying with Apple-internal stakeholders and experts:

- Switch WebKit support for EUC-TW from TEC to ICU.
- Entirely remove WebKit support for all other encodings currently handled with TEC.
Comment 3 Maciej Stachowiak 2017-11-17 23:39:23 PST
Created attachment 327303 [details]
Patch
Comment 4 WebKit Commit Bot 2017-11-18 19:42:53 PST
Comment on attachment 327303 [details]
Patch

Clearing flags on attachment: 327303

Committed r225027: <https://trac.webkit.org/changeset/225027>
Comment 5 WebKit Commit Bot 2017-11-18 19:42:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-18 19:43:22 PST
<rdar://problem/35635080>