Bug 179570 - Web Inspector: Network Tab - Add HAR Export button
Summary: Web Inspector: Network Tab - Add HAR Export button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-10 17:20 PST by Joseph Pecoraro
Modified: 2017-11-17 15:33 PST (History)
6 users (show)

See Also:

Attachments
[IMAGE] Export Button (61.65 KB, image/png)
2017-11-17 14:00 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (9.12 KB, patch)
2017-11-17 14:00 PST, Joseph Pecoraro 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-10 17:20:40 PST 
Network Tab - Add HAR Export button

This will improve discoverability of the Export feature. And later we can add an import.
Comment 1 Radar WebKit Bug Importer 2017-11-10 19:16:14 PST 
<rdar://problem/35484918>
Comment 2 Joseph Pecoraro 2017-11-17 14:00:06 PST 
Created attachment 327231 [details]
[IMAGE] Export Button
Comment 3 Joseph Pecoraro 2017-11-17 14:00:21 PST 
Created attachment 327232 [details]
[PATCH] Proposed Fix
Comment 4 Matt Baker 2017-11-17 15:07:39 PST 
Comment on attachment 327232 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327232&action=review

Looks great, r=me

> Source/WebInspectorUI/UserInterface/Images/Export.svg:5
> +    <path fill="none" stroke="currentColor" d="M 4.5 5 l 3-3 l 3 3"/>

Nit: 3-3 -> 3 -3

> Source/WebInspectorUI/UserInterface/Images/Import.svg:5
> +    <path fill="none" stroke="currentColor" d="M 10.5 5.5l-3,3 l -3-3"/>    

Nit: d="M 10.5 5.5l-3,3 l -3-3" -> d="M 10.5 5.5 l -3 3 l -3 -3"
Comment 5 Joseph Pecoraro 2017-11-17 15:33:14 PST 
<https://trac.webkit.org/changeset/224994/webkit>