REGRESSION(r223856): Web Inspector: Cannot view Request Data

[Joseph Pecoraro]

REGRESSION(r223856): Cannot view Request Data

Oops, a condition flipped in r223856.

[Joseph Pecoraro]

Created attachment 326664 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 326664 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326664&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:216
> +        if (this._resource.hasRequestFormParameters())

I realize that this existed before the new Network tab, but I think now would be a good time to add a comment.  To me, this seems backwards, as we would want to show request data if we have form parameters.  My guess is that that is either a security concern or we have a different UI for this?  Either way, I don't know why this is the case right now.

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 326664 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326664&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:216
> > +        if (this._resource.hasRequestFormParameters())
> 
> I realize that this existed before the new Network tab, but I think now
> would be a good time to add a comment.  To me, this seems backwards, as we
> would want to show request data if we have form parameters.  My guess is
> that that is either a security concern or we have a different UI for this? 
> Either way, I don't know why this is the case right now.

If the data is Form Parameters (x-www-form-urlencoded) then the data is key/value pairs like query string data. We show that in the "Headers" view like query string parameters. I suppose we could have a view here that shows them like query string parameters, but right now we only prefer showing a ContentView for requestData that is data.

[BJ Burg]

Comment on attachment 326664 [details]
[PATCH] Proposed Fix

r=me

[Radar WebKit Bug Importer]

<rdar://problem/35510405>

[WebKit Commit Bot]

Comment on attachment 326664 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 326664

Committed r224767: <https://trac.webkit.org/changeset/224767>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.