Bug 179562 – We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming soon.

<rdar://problem/35467022>

[Mark Lam]

Created attachment 326667 [details]
proposed patch.

[Saam Barati]

Comment on attachment 326667 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=326667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> +                    m_insertionSet.insertNode(
> +                        m_indexInBlock, SpecNone, Check, node->origin,
> +                        Edge(edge.node(), NotSymbolUse));

Might be worth a comment saying why we do this.

[Mark Lam]

(In reply to Saam Barati from comment #2)
> > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> > +                    m_insertionSet.insertNode(
> > +                        m_indexInBlock, SpecNone, Check, node->origin,
> > +                        Edge(edge.node(), NotSymbolUse));
> 
> Might be worth a comment saying why we do this.

Thanks.  I will add the comment.

[Mark Lam]

Landed in r224735: <http://trac.webkit.org/r224735>.