Bug 179562 - We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments.
Summary: We should ensure that operationStrCat2 and operationStrCat3 are never passed ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-10 16:46 PST by Mark Lam
Modified: 2017-11-12 07:35 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (10.70 KB, patch)
2017-11-10 17:42 PST, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-11-10 16:46:02 PST
Patch coming soon.

<rdar://problem/35467022>
Comment 1 Mark Lam 2017-11-10 17:42:26 PST
Created attachment 326667 [details]
proposed patch.
Comment 2 Saam Barati 2017-11-10 17:47:53 PST
Comment on attachment 326667 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=326667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> +                    m_insertionSet.insertNode(
> +                        m_indexInBlock, SpecNone, Check, node->origin,
> +                        Edge(edge.node(), NotSymbolUse));

Might be worth a comment saying why we do this.
Comment 3 Mark Lam 2017-11-10 17:48:37 PST
(In reply to Saam Barati from comment #2)
> > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> > +                    m_insertionSet.insertNode(
> > +                        m_indexInBlock, SpecNone, Check, node->origin,
> > +                        Edge(edge.node(), NotSymbolUse));
> 
> Might be worth a comment saying why we do this.

Thanks.  I will add the comment.
Comment 4 Mark Lam 2017-11-12 07:35:02 PST
Landed in r224735: <http://trac.webkit.org/r224735>.