Bug 179560 – Web Inspector: Give DataGrid/Table Header ContextMenu a section header to better describe its functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Give DataGrid/Table Header ContextMenu a section header to better describe its functions

Most noticeable in the Network Table but any table that can toggle showing/hiding columns.

[Joseph Pecoraro]

Created attachment 326651 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 326652 [details]
[IMAGE] After

[Joseph Pecoraro]

Created attachment 326653 [details]
[PATCH] Proposed Fix

[Matt Baker]

(In reply to Joseph Pecoraro from comment #2)
> Created attachment 326652 [details]
> [IMAGE] After

I'm not sure this approach is better. Do we have examples of system UI or a commonly used app that does this?

[Joseph Pecoraro]

> I'm not sure this approach is better. Do we have examples of system UI or a
> commonly used app that does this?

I could go either way. Safari has this in its Mute tabs context menus, but with a bit of other flair. Mail/Finder don't have things like this for their tables.

[Matt Baker]

Comment on attachment 326653 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326653&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1637
> +                    contextMenu.appendItem(WI.UIString("Displayed Columns"), () => {}, disabled);

What do you think about simply "Columns"?

[Joseph Pecoraro]

> > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1637
> > +                    contextMenu.appendItem(WI.UIString("Displayed Columns"), () => {}, disabled);
> 
> What do you think about simply "Columns"?

I had that and was convinced to switch to Displayed Columns, which provides a little more information about what the Check marks mean.

[WebKit Commit Bot]

Comment on attachment 326653 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 326653

Committed r224761: <https://trac.webkit.org/changeset/224761>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562195>