Bug 179553 - [Windows] Fix Python error for subprocess.popen with close_fds
Summary: [Windows] Fix Python error for subprocess.popen with close_fds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 179216
  Show dependency tree / graph
 
Reported: 2017-11-10 15:11 PST by Basuke Suzuki
Modified: 2017-11-15 09:35 PST (History)
12 users (show)

See Also:

Attachments
fix (2.56 KB, patch)
2017-11-13 14:10 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-11-10 15:11:26 PST 
When running test-webkitpy, there're many failure caused by following error:

>   ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr
Comment 1 Basuke Suzuki 2017-11-10 15:11:49 PST 
On Windows native command prompt (not Cygwin)
Comment 2 Basuke Suzuki 2017-11-13 14:10:35 PST 
Created attachment 326798 [details]
fix
Comment 3 Basuke Suzuki 2017-11-13 14:16:28 PST 
I chose just passing False (don't close fds) because we cannot move forward with this flag True on Windows w/o Cygwin. We will figured out the actual issue caused by passing False here later.
Comment 4 Per Arne Vollan 2017-11-13 15:56:16 PST 
Comment on attachment 326798 [details]
fix

R=me.
Comment 5 WebKit Commit Bot 2017-11-13 16:55:45 PST 
Comment on attachment 326798 [details]
fix

Clearing flags on attachment: 326798

Committed r224795: <https://trac.webkit.org/changeset/224795>
Comment 6 WebKit Commit Bot 2017-11-13 16:55:46 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:35:33 PST 
<rdar://problem/35562026>