Bug 179551 – Implement basics of "Terminate Service Worker" algorithm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Implement basics of "Terminate Service Worker" algorithm

Basics only because we don't yet support some of the stuff explicitly covered by this algorithm.

[Brady Eidson]

Created attachment 327015 [details]
Patch

[Chris Dumez]

Comment on attachment 327015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327015&action=review

r=me with comment

> Source/WebCore/workers/WorkerThread.cpp:232
> +        RunLoop::main().dispatch(WTFMove(m_stoppedCallback));

This is in Webcore, shouldn't it be a callOnMainThread() ?

[Brady Eidson]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 327015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327015&action=review
> 
> r=me with comment
> 
> > Source/WebCore/workers/WorkerThread.cpp:232
> > +        RunLoop::main().dispatch(WTFMove(m_stoppedCallback));
> 
> This is in Webcore, shouldn't it be a callOnMainThread() ?

There's a few RunLoop::main.dispatches in WebCore, including in this very file!

But I will change.

[Brady Eidson]

Created attachment 327027 [details]
Patch

[Build Bot]

Comment on attachment 327027 [details]
Patch

Attachment 327027 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5251765

New failing tests:
fast/events/message-port-postMessage-recursive.html

[Build Bot]

Created attachment 327036 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

Comment on attachment 327027 [details]
Patch

That failure was almost certainly a preexisting flake unrelated to this test

[Brady Eidson]

(In reply to Brady Eidson from comment #7)
> Comment on attachment 327027 [details]
> Patch
> 
> That failure was almost certainly a preexisting flake unrelated to this test

I meant “this patch”

[WebKit Commit Bot]

Comment on attachment 327027 [details]
Patch

Clearing flags on attachment: 327027

Committed r224909: <https://trac.webkit.org/changeset/224909>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35579132>