Bug 179550 - [JSC] Allow poly proto for intrinsic getters
Summary: [JSC] Allow poly proto for intrinsic getters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-10 15:04 PST by Yusuke Suzuki
Modified: 2017-11-21 02:08 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.98 KB, patch)
2017-11-10 15:07 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-10 15:04:22 PST 
[JSC] Allow poly proto for intrinsic getters
Comment 1 Yusuke Suzuki 2017-11-10 15:07:39 PST 
Created attachment 326637 [details]
Patch
Comment 2 Darin Adler 2017-11-20 07:53:14 PST 
Comment on attachment 326637 [details]
Patch

I’d love to review, but I’m not quite expert enough in the JIT.
Comment 3 Saam Barati 2017-11-20 08:52:08 PST 
Comment on attachment 326637 [details]
Patch

Another interesting test would be to do this with a second object:
polyProtoObject.__proto__ = null
assert(target(polyProtoObject) === undefined)
Comment 4 Yusuke Suzuki 2017-11-21 02:00:14 PST 
(In reply to Saam Barati from comment #3)
> Comment on attachment 326637 [details]
> Patch
> 
> Another interesting test would be to do this with a second object:
> polyProtoObject.__proto__ = null
> assert(target(polyProtoObject) === undefined)

Sounds good. Added.
Comment 5 Yusuke Suzuki 2017-11-21 02:07:59 PST 
Committed r225071: <https://trac.webkit.org/changeset/225071>
Comment 6 Radar WebKit Bug Importer 2017-11-21 02:08:19 PST 
<rdar://problem/35654956>