179544 – Enable Modern EME tests in DumpRenderTree

Bug 179544 - Enable Modern EME tests in DumpRenderTree

Summary: Enable Modern EME tests in DumpRenderTree

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Jer Noble

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-11-10 13:57 PST by Jer Noble
Modified:	2017-11-15 09:38 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (6.10 KB, patch) 2017-11-10 13:59 PST, Jer Noble	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.20 MB, application/zip) 2017-11-10 14:56 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (2.88 MB, application/zip) 2017-11-10 15:31 PST, Build Bot	no flags	Details
Patch (8.51 KB, patch) 2017-11-13 17:30 PST, Jer Noble	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jer Noble 2017-11-10 13:57:52 PST

Enable Modern EME tests in DumpRenderTree

Comment 1 Jer Noble 2017-11-10 13:59:22 PST

Created attachment 326626 [details]
Patch

Comment 2 Build Bot 2017-11-10 14:56:07 PST Comment hidden (obsolete)

Comment on attachment 326626 [details]
Patch

Attachment 326626 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5182396

New failing tests:
fast/dom/navigator-detached-no-crash.html

Comment 3 Build Bot 2017-11-10 14:56:08 PST Comment hidden (obsolete)

Created attachment 326635 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 4 Alex Christensen 2017-11-10 15:21:09 PST

Comment on attachment 326626 [details]
Patch

Should this also enable some tests?

Comment 5 Build Bot 2017-11-10 15:31:14 PST Comment hidden (obsolete)

Comment on attachment 326626 [details]
Patch

Attachment 326626 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5182580

New failing tests:
fast/dom/navigator-detached-no-crash.html

Comment 6 Build Bot 2017-11-10 15:31:15 PST Comment hidden (obsolete)

Created attachment 326642 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 7 Ryan Haddad 2017-11-13 16:50:04 PST

Disabled two tests on mac-wk1 in https://trac.webkit.org/r224794. They can be re-enabled when this change lands.

Comment 8 Jer Noble 2017-11-13 17:30:46 PST

Created attachment 326831 [details]
Patch

Comment 9 Jer Noble 2017-11-13 17:31:51 PST

(In reply to Alex Christensen from comment #4)
> Comment on attachment 326626 [details]
> Patch
> 
> Should this also enable some tests?

The most recent patch updates one test expectation and enables two tests.

Comment 10 WebKit Commit Bot 2017-11-14 12:29:09 PST

Comment on attachment 326831 [details]
Patch

Clearing flags on attachment: 326831

Committed r224833: <https://trac.webkit.org/changeset/224833>

Comment 11 WebKit Commit Bot 2017-11-14 12:29:11 PST

All reviewed patches have been landed.  Closing bug.

Comment 12 Radar WebKit Bug Importer 2017-11-15 09:38:01 PST

<rdar://problem/35562105>