Bug 179533 - [GTK] Enable some passing XHR tests
Summary: [GTK] Enable some passing XHR tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-10 08:59 PST by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2017-11-13 01:28 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.94 KB, patch)
2017-11-10 09:09 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-10 08:59:28 PST 
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-10 09:09:43 PST 
Created attachment 326593 [details]
Patch
Comment 2 Alex Christensen 2017-11-10 13:56:52 PST 
Comment on attachment 326593 [details]
Patch

Are these tests passing on GTK but not on Cocoa because of bugs in CFNetwork, or because of GTK-specific code in the loader?  If the latter, then we should just fix them everywhere.  If the former, then we'll have to fix them internally.
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-13 01:08:31 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 326593 [details]
> Patch
> 
> Are these tests passing on GTK but not on Cocoa because of bugs in
> CFNetwork, or because of GTK-specific code in the loader?  If the latter,
> then we should just fix them everywhere.  If the former, then we'll have to
> fix them internally.

I suspect the former; I filed bug 179604 to track.
Comment 4 WebKit Commit Bot 2017-11-13 01:28:57 PST 
Comment on attachment 326593 [details]
Patch

Clearing flags on attachment: 326593

Committed r224750: <https://trac.webkit.org/changeset/224750>
Comment 5 WebKit Commit Bot 2017-11-13 01:28:59 PST 
All reviewed patches have been landed.  Closing bug.