Bug 179524 - WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
Summary: WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 23:10 PST by Fujii Hironori
Modified: 2017-11-15 09:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2017-11-09 23:38 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-11-09 23:10:37 PST 
Bug 179276 has introduced a new warning message.
(GTK port, Release build, trunk@224623)

> [1195/2773] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource267.cpp.o
> In file included from DerivedSources/WebCore/unified-sources/UnifiedSource267.cpp:5:0:
> ../../Source/WebCore/inspector/WebInjectedScriptHost.cpp: In member function ‘virtual JSC::JSValue WebCore::WebInjectedScriptHost::getInternalProperties(JSC::VM&, JSC::ExecState*, JSC::JSValue)’:
> ../../Source/WebCore/inspector/WebInjectedScriptHost.cpp:165:10: warning: variable ‘scope’ set but not used [-Wunused-but-set-variable]
>      auto scope = DECLARE_THROW_SCOPE(vm);
>           ^~~~~
Comment 1 Fujii Hironori 2017-11-09 23:11:58 PST 
Joseph is in Bug 179276 Comment 21.
Comment 2 Fujii Hironori 2017-11-09 23:12:15 PST 
Joseph's patch is in Bug 179276 Comment 21.
Comment 3 Joseph Pecoraro 2017-11-09 23:33:41 PST 
You can just land build fixes if you can verify it
Comment 4 Fujii Hironori 2017-11-09 23:38:17 PST 
Created attachment 326565 [details]
Patch
Comment 5 WebKit Commit Bot 2017-11-10 00:30:32 PST 
Comment on attachment 326565 [details]
Patch

Clearing flags on attachment: 326565

Committed r224670: <https://trac.webkit.org/changeset/224670>
Comment 6 WebKit Commit Bot 2017-11-10 00:30:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:36:11 PST 
<rdar://problem/35562044>