Bug 179521 - Rebaseline flaky / skipped service worker tests
Summary: Rebaseline flaky / skipped service worker tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 21:16 PST by Chris Dumez
Modified: 2017-11-15 09:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (33.58 KB, patch)
2017-11-09 21:20 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (32.10 KB, patch)
2017-11-09 21:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-09 21:16:37 PST 
Rebaseline flaky / skipped service worker tests.
Comment 1 Chris Dumez 2017-11-09 21:20:40 PST 
Created attachment 326549 [details]
Patch
Comment 2 Chris Dumez 2017-11-09 21:26:38 PST 
Created attachment 326551 [details]
Patch
Comment 3 Chris Dumez 2017-11-09 22:06:17 PST 
Committed r224663: <https://trac.webkit.org/changeset/224663>
Comment 4 youenn fablet 2017-11-09 22:26:28 PST 
Comment on attachment 326551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review

> LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:25
> +CONSOLE MESSAGE: Origin https://localhost:9443 is not allowed by Access-Control-Allow-Origin.

Messages here are probably not always printed in the same order due to some async nature of the test, hence the flakiness.
We might probably need to use DumpConsoleLogInStderr expectation to remove this console logs.
Dashboard should let us know that.
Comment 5 youenn fablet 2017-11-09 23:49:15 PST 
Comment on attachment 326551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review

> LayoutTests/TestExpectations:-169
> -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ]

Test seems flaky on EWS.
Comment 6 Chris Dumez 2017-11-10 07:08:13 PST 
(In reply to youenn fablet from comment #5)
> Comment on attachment 326551 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326551&action=review
> 
> > LayoutTests/TestExpectations:-169
> > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ]
> 
> Test seems flaky on EWS.

<https://trac.webkit.org/changeset/224680>
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:37:38 PST 
<rdar://problem/35562091>