Bug 179519 - Rebase some layout tests
Summary: Rebase some layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 19:26 PST by Megan Gardner
Modified: 2017-11-10 14:37 PST (History)
8 users (show)

See Also:


Attachments
Patch (11.41 KB, patch)
2017-11-09 19:28 PST, Megan Gardner
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-11-09 19:26:38 PST
Rebase some layout tests
Comment 1 Megan Gardner 2017-11-09 19:28:35 PST
Created attachment 326534 [details]
Patch
Comment 2 Tim Horton 2017-11-09 21:20:56 PST
Comment on attachment 326534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326534&action=review

> LayoutTests/platform/ios-wk2/TestExpectations:1227
> +editing/selection/3690703-2.html [ Pass ]

For these, did you check the flakiness dashboard to see if they’ve been stable on the bots recently?
Comment 3 Alex Christensen 2017-11-10 14:05:53 PST
Comment on attachment 326534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326534&action=review

>> LayoutTests/platform/ios-wk2/TestExpectations:1227
>> +editing/selection/3690703-2.html [ Pass ]
> 
> For these, did you check the flakiness dashboard to see if they’ve been stable on the bots recently?

They're always failing.  The rebasing will make them either always pass or become flaky.  You might want to land the rebasing, wait a weekend, then mark the non-flaky ones as passing.
Comment 4 Radar WebKit Bug Importer 2017-11-10 14:35:25 PST
<rdar://problem/35478419>
Comment 5 Megan Gardner 2017-11-10 14:37:02 PST
https://trac.webkit.org/r224706