Bug 179508 - [WinCairo] Cannot find ImageDiff executable
Summary: [WinCairo] Cannot find ImageDiff executable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 179216
  Show dependency treegraph
 
Reported: 2017-11-09 15:17 PST by Basuke Suzuki
Modified: 2017-11-15 09:43 PST (History)
11 users (show)

See Also:


Attachments
patch (2.11 KB, patch)
2017-11-09 15:30 PST, Basuke Suzuki
pvollan: review+
Details | Formatted Diff | Diff
fix (2.11 KB, patch)
2017-11-09 16:09 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff
fix reviewer (2.11 KB, patch)
2017-11-09 16:11 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-11-09 15:17:07 PST
Without Cygwin, it cannot find ImageDiff executable.
Comment 1 Basuke Suzuki 2017-11-09 15:30:17 PST
Created attachment 326495 [details]
patch
Comment 2 Per Arne Vollan 2017-11-09 15:56:59 PST
Comment on attachment 326495 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326495&action=review

R=me.

> Tools/Scripts/webkitpy/port/win.py:165
> +        """Return current platform is Cygwin or not"""

Perhaps change this to "Return whether current platform is Cygwin or not".
Comment 3 Basuke Suzuki 2017-11-09 16:09:13 PST
Created attachment 326501 [details]
fix
Comment 4 Basuke Suzuki 2017-11-09 16:11:39 PST
Created attachment 326504 [details]
fix reviewer
Comment 5 WebKit Commit Bot 2017-11-09 16:48:54 PST
Comment on attachment 326504 [details]
fix reviewer

Clearing flags on attachment: 326504

Committed r224656: <https://trac.webkit.org/changeset/224656>
Comment 6 WebKit Commit Bot 2017-11-09 16:48:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:43:35 PST
<rdar://problem/35562313>