RESOLVED FIXED179503
Make CachedResource::redirectReceived asynchronous 
https://bugs.webkit.org/show_bug.cgi?id=179503
Summary Make CachedResource::redirectReceived asynchronous
Alex Christensen
Reported 2017-11-09 12:02:00 PST
Make CachedResource::redirectReceived asynchronous
Attachments
Patch (27.72 KB, patch)
2017-11-09 12:04 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.73 KB, patch)
2017-11-09 12:55 PST, Alex Christensen 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-11-09 12:04:56 PST
Created attachment 326475 [details] Patch
Alex Christensen
Comment 2 2017-11-09 12:55:17 PST
Created attachment 326479 [details] Patch
Antti Koivisto
Comment 3 2017-11-10 10:55:12 PST
Comment on attachment 326479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326479&action=review > Source/WebCore/loader/SubresourceLoader.cpp:186 > + auto callSuper = [this, protectedThis = makeRef(*this), redirectResponse] (CompletionHandler<void(ResourceRequest&&)>&& completionHandler, ResourceRequest&& newRequest) mutable { "callSuper" is not a great name. Can you name this with something that describes what it is actually trying to accomplish? > Source/WebCore/loader/cache/CachedRawResource.cpp:119 > +static void iterate(CachedResourceHandle<CachedRawResource>&& handle, CachedRawResourceClient& client, Vector<std::pair<ResourceRequest, ResourceResponse>>&& redirectsInReverseOrder, CompletionHandler<void(ResourceRequest&&)>&& completionHandler) iterate over what?
Alex Christensen
Comment 4 2017-11-10 11:24:13 PST
(In reply to Antti Koivisto from comment #3) > "callSuper" is not a great name. Can you name this with something that > describes what it is actually trying to accomplish? I renamed this to continueWillSendRequest. > iterate over what? I renamed these to iterateClients and iterateRedirects. http://trac.webkit.org/r224699
Radar WebKit Bug Importer
Comment 5 2017-11-15 09:37:48 PST
<rdar://problem/35562097>
Note You need to log in before you can comment on or make changes to this bug.