Bug 179490 - ResourceErrorBase::setType should not ASSERT if it is a no op
Summary: ResourceErrorBase::setType should not ASSERT if it is a no op
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 10:26 PST by youenn fablet
Modified: 2017-11-15 09:43 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2017-11-09 10:27 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-09 10:26:50 PST 
Sometimes, our code base is setting twice setType with the same value when doing navigation loads through ServiceWorker.
Comment 1 youenn fablet 2017-11-09 10:27:40 PST 
Created attachment 326466 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-09 11:01:02 PST 
Comment on attachment 326466 [details]
Patch

Clearing flags on attachment: 326466

Committed r224638: <https://trac.webkit.org/changeset/224638>
Comment 3 WebKit Commit Bot 2017-11-09 11:01:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-11-15 09:43:19 PST 
<rdar://problem/35562306>