Bug 179487 - FetchResponse should set the mime type of its internal ResourceResponse
Summary: FetchResponse should set the mime type of its internal ResourceResponse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 09:17 PST by youenn fablet
Modified: 2017-11-15 09:38 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2017-11-09 09:26 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2017-11-09 09:36 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2017-11-09 12:30 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-09 09:17:09 PST
This mime type is used for navigation tasks.
If going through Service Worker, the mime type would not be set now.
Comment 1 youenn fablet 2017-11-09 09:26:21 PST
Created attachment 326457 [details]
Patch
Comment 2 youenn fablet 2017-11-09 09:36:58 PST
Created attachment 326459 [details]
Patch
Comment 3 Chris Dumez 2017-11-09 10:50:25 PST
Comment on attachment 326459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326459&action=review

> Source/WebCore/platform/network/ResourceResponseBase.h:82
> +    void sniffMimeTypeIfNeeded(const String& contentType);

Not a fan of having a sniffing method on the resourceResponse itself.
Comment 4 youenn fablet 2017-11-09 12:30:38 PST
Created attachment 326478 [details]
Patch
Comment 5 WebKit Commit Bot 2017-11-09 13:09:27 PST
Comment on attachment 326478 [details]
Patch

Clearing flags on attachment: 326478

Committed r224645: <https://trac.webkit.org/changeset/224645>
Comment 6 WebKit Commit Bot 2017-11-09 13:09:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:38:09 PST
<rdar://problem/35562115>