Bug 179486 - ServiceWorker ResourceResponse should not assert in platformCertificateInfo()
Summary: ServiceWorker ResourceResponse should not assert in platformCertificateInfo()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 09:13 PST by youenn fablet
Modified: 2017-11-15 09:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2017-11-09 09:16 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2017-11-09 11:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-11-09 09:13:43 PST 
ServiceWorker ResourceResponse should not assert in platformCertificateInfo()
Comment 1 youenn fablet 2017-11-09 09:16:02 PST 
Created attachment 326455 [details]
Patch
Comment 2 Sam Weinig 2017-11-09 11:07:14 PST 
Comment on attachment 326455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326455&action=review

> Source/WebCore/ChangeLog:10
> +        In that case, platformCertificateInfo should return std::nullopt.

platformCertificateInfo doesn't return an optional, so I don't think this makes sense. It just returns a default constructed CertificateInfo.
Comment 3 youenn fablet 2017-11-09 11:48:02 PST 
Created attachment 326473 [details]
Patch
Comment 4 WebKit Commit Bot 2017-11-09 12:58:19 PST 
Comment on attachment 326473 [details]
Patch

Clearing flags on attachment: 326473

Committed r224644: <https://trac.webkit.org/changeset/224644>
Comment 5 WebKit Commit Bot 2017-11-09 12:58:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 09:39:22 PST 
<rdar://problem/35562166>