Bug 179484 - [LayoutState cleanup] LayoutState::m_lineGrid should be a weak pointer
Summary: [LayoutState cleanup] LayoutState::m_lineGrid should be a weak pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 09:03 PST by zalan
Modified: 2017-11-09 10:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.13 KB, patch)
2017-11-09 09:13 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-11-09 09:03:06 PST 
ssia.
Comment 1 Radar WebKit Bug Importer 2017-11-09 09:04:15 PST 
<rdar://problem/35442725>
Comment 2 zalan 2017-11-09 09:13:00 PST 
Created attachment 326454 [details]
Patch
Comment 3 Darin Adler 2017-11-09 09:22:36 PST 
Comment on attachment 326454 [details]
Patch

Didn’t need to add any null checks?
Comment 4 zalan 2017-11-09 10:02:40 PST 
(In reply to Darin Adler from comment #3)
> Comment on attachment 326454 [details]
> Patch
> 
> Didn’t need to add any null checks?
We already check for null on m_lineGrid.
Comment 5 WebKit Commit Bot 2017-11-09 10:22:01 PST 
Comment on attachment 326454 [details]
Patch

Clearing flags on attachment: 326454

Committed r224632: <https://trac.webkit.org/changeset/224632>
Comment 6 WebKit Commit Bot 2017-11-09 10:22:03 PST 
All reviewed patches have been landed.  Closing bug.