Bug 179483 – [LayoutState cleanup] Remove renderer data members from state maintainers.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

Although layout is not supposed to mutate the tree, it's safer not to have them as data members.

[Radar WebKit Bug Importer]

<rdar://problem/35442548>

[alan]

Created attachment 326452 [details]
Patch

[Darin Adler]

Comment on attachment 326452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326452&action=review

> Source/WebCore/rendering/LayoutState.h:165
> +    LayoutContext* m_layoutContext { nullptr };

I would have just called this "m_acontext" since the class is all about layout and has layout in its name.

> Source/WebCore/rendering/LayoutState.h:185
> +    LayoutContext& m_layoutContext;

Ditto.

[alan]

(In reply to Darin Adler from comment #3)
> Comment on attachment 326452 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326452&action=review
> 
> > Source/WebCore/rendering/LayoutState.h:165
> > +    LayoutContext* m_layoutContext { nullptr };
> 
> I would have just called this "m_acontext" since the class is all about
> layout and has layout in its name.
Indeed.

[alan]

Created attachment 326465 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 326465 [details]
Patch

Clearing flags on attachment: 326465

Committed r224637: <https://trac.webkit.org/changeset/224637>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.