Although layout is not supposed to mutate the tree, it's safer not to have them as data members.
<rdar://problem/35442548>
Created attachment 326452 [details] Patch
Comment on attachment 326452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326452&action=review > Source/WebCore/rendering/LayoutState.h:165 > + LayoutContext* m_layoutContext { nullptr }; I would have just called this "m_acontext" since the class is all about layout and has layout in its name. > Source/WebCore/rendering/LayoutState.h:185 > + LayoutContext& m_layoutContext; Ditto.
(In reply to Darin Adler from comment #3) > Comment on attachment 326452 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326452&action=review > > > Source/WebCore/rendering/LayoutState.h:165 > > + LayoutContext* m_layoutContext { nullptr }; > > I would have just called this "m_acontext" since the class is all about > layout and has layout in its name. Indeed.
Created attachment 326465 [details] Patch
Comment on attachment 326465 [details] Patch Clearing flags on attachment: 326465 Committed r224637: <https://trac.webkit.org/changeset/224637>
All reviewed patches have been landed. Closing bug.