WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
179478
[JSC] Optimize default constructor implementation for derived class with array iterator protocol check
https://bugs.webkit.org/show_bug.cgi?id=179478
Summary
[JSC] Optimize default constructor implementation for derived class with arra...
Yusuke Suzuki
Reported
2017-11-09 07:44:48 PST
Current default constructor implementation for derived class is, constructor(...args) { super(...args); } But the above code allocates arrays until FTL while that is apparently unnecessary for many cases. It makes super() call construct_varargs with opaque array... Which is not good since DFGByteCodeParser do not handle it well if the constructor is non JS. So, extends Array case is not optimized well in this case. We would like to explore the performance improvement by changing this to constructor(...args) { if (@isArrayIteratorProtocolFastAndNonObservable()) { @superForwardArguments(); return; } super(@spread()); }
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug