Bug 179474 – [WinCairo] Add network (curl) files for wincairo webkit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yousuke Kimoto]

Add network files related to curl for wincairo webkit.

[Yousuke Kimoto]

Created attachment 326853 [details]
[PATCH] Add network (curl) files for WinCairo WebKit

[Build Bot]

Comment on attachment 326853 [details]
[PATCH] Add network (curl) files for WinCairo WebKit

Attachment 326853 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5224256

New failing tests:
http/tests/workers/service/service-worker-clear.html

[Build Bot]

Created attachment 326862 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Don Olmstead]

WinCairo EWS is failing because of r224791 but other than that it should be okay to review. Not sure what's up with ios-sim as this patch has no ios modifications.

[Alex Christensen]

Comment on attachment 326853 [details]
[PATCH] Add network (curl) files for WinCairo WebKit

View in context: https://bugs.webkit.org/attachment.cgi?id=326853&action=review

> Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69
> +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&)

This will need rebasing after https://trac.webkit.org/changeset/224791/webkit

[Don Olmstead]

Created attachment 326929 [details]
Rebased

Rebasing patch

[Don Olmstead]

Created attachment 326931 [details]
Rebased

[Yousuke Kimoto]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 326853 [details]
> [PATCH] Add network (curl) files for WinCairo WebKit
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326853&action=review
> 
> > Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69
> > +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&)
> 
> This will need rebasing after https://trac.webkit.org/changeset/224791/webkit

ensurePrivateBrowsingSession() must be removed from attachment 326853 [details], I'll do that.

[Yousuke Kimoto]

Created attachment 327141 [details]
[PATCH] Add network (curl) files for wincairo webkit

[EWS Watchlist]

Comment on attachment 327141 [details]
[PATCH] Add network (curl) files for wincairo webkit

Attachment 327141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5267705

New failing tests:
http/tests/appcache/offline-access.html

[EWS Watchlist]

Created attachment 327144 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Yousuke Kimoto]

Created attachment 327145 [details]
[PATCH] Add network (curl) files for wincairo webkit

Just updated reviewer's line.

[WebKit Commit Bot]

Comment on attachment 327145 [details]
[PATCH] Add network (curl) files for wincairo webkit

Clearing flags on attachment: 327145

Committed r224961: <https://trac.webkit.org/changeset/224961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35608759>