Async iteration should only fetch the next method once and add feature flag
Created attachment 326396 [details] Patch
Comment on attachment 326396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326396&action=review > Source/JavaScriptCore/ChangeLog:9 > + the expected behavior of the proposal. Looks good to me, but not sure that we have tests that cover this case.
Comment on attachment 326396 [details] Patch r=me
Committed r224787: <https://trac.webkit.org/changeset/224787>
Should we also enable this feature for CMake builds?
(In reply to Per Arne Vollan from comment #5) > Should we also enable this feature for CMake builds? Yeah. Keith, what was the motivation for adding a build flag here?
(In reply to Saam Barati from comment #6) > (In reply to Per Arne Vollan from comment #5) > > Should we also enable this feature for CMake builds? > > Yeah. Yeah, I'll add one for CMake. > > Keith, what was the motivation for adding a build flag here? The feature has not reached stage 4 yet so we don't want to accidentally ship the feature.
(In reply to Keith Miller from comment #7) > (In reply to Saam Barati from comment #6) > > (In reply to Per Arne Vollan from comment #5) > > > Should we also enable this feature for CMake builds? > > > > Yeah. > > Yeah, I'll add one for CMake. > > > > > Keith, what was the motivation for adding a build flag here? > > The feature has not reached stage 4 yet so we don't want to accidentally > ship the feature. But we have a runtime option already, right?
<rdar://problem/35562169>
(In reply to Saam Barati from comment #8) > But we have a runtime option already, right? Where are JSC runtime options defined? (In reply to Keith Miller from comment #7) > The feature has not reached stage 4 yet so we don't want to accidentally > ship the feature. Is any precaution taken to ensure it's not already shipping on CMake ports? E.g. is it gated behind ENABLE(DEVELOPER_MODE)? For WebKit-level features, that's easy to accomplish by setting defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED in WebPreferences.yaml. But I don't know how this is handled for JSC.
(In reply to Michael Catanzaro from comment #10) > Where are JSC runtime options defined? They are in Source/JavaScriptCore/runtime/Options.* > Is any precaution taken to ensure it's not already shipping on CMake ports? > E.g. is it gated behind ENABLE(DEVELOPER_MODE)? For WebKit-level features, > that's easy to accomplish by setting defaultValue: > DEFAULT_EXPERIMENTAL_FEATURES_ENABLED in WebPreferences.yaml. But I don't > know how this is handled for JSC. This feature was only added in the last month or so. Unless someone shipped in the last month they won't have the feature. I don't think JSC has anything like experimental features in WebKit.