Bug 179442 - REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
Summary: REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-08 13:19 PST by Ryosuke Niwa
Modified: 2017-11-13 19:47 PST (History)
8 users (show)

See Also:

Attachments
Disable assertins in iOS (1.77 KB, patch)
2017-11-08 13:20 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-11-08 13:19:13 PST 
REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded
Comment 1 Ryosuke Niwa 2017-11-08 13:20:45 PST 
Created attachment 326355 [details]
Disable assertins in iOS
Comment 2 Simon Fraser (smfr) 2017-11-08 13:26:44 PST 
rdar://problem/35421652
Comment 3 WebKit Commit Bot 2017-11-08 15:54:19 PST 
Comment on attachment 326355 [details]
Disable assertins in iOS

Clearing flags on attachment: 326355

Committed r224604: <https://trac.webkit.org/changeset/224604>
Comment 4 WebKit Commit Bot 2017-11-08 15:54:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2017-11-08 18:59:24 PST 
Comment on attachment 326355 [details]
Disable assertins in iOS

View in context: https://bugs.webkit.org/attachment.cgi?id=326355&action=review

> Source/WebCore/dom/Document.cpp:1942
> +#if !USE(WEB_THREAD)

How does this work? We don't have separate WebCore builds for WebKit2 and legacy WebKit, so won't this completely disable the assertion on iOS?
Comment 6 Simon Fraser (smfr) 2017-11-08 19:42:45 PST 
Yes, it does. We plan to re-enable the assertion after some bug fixing.
Comment 7 Ryosuke Niwa 2017-11-08 23:10:56 PST 
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 326355 [details]
> Disable assertins in iOS
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326355&action=review
> 
> > Source/WebCore/dom/Document.cpp:1942
> > +#if !USE(WEB_THREAD)
> 
> How does this work? We don't have separate WebCore builds for WebKit2 and
> legacy WebKit, so won't this completely disable the assertion on iOS?

Yes. That's the intent to unblock the submission. I intend on fixing the assertion next week when I actually have an engineering time.