Bug 179427 – Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Michael Catanzaro]

r224555 "We should PROT_NONE the Gigacage runway so OOB accesses crash" introduced this GCC warning:

[15/2288] Building CXX object Source/b...les/bmalloc.dir/bmalloc/Gigacage.cpp.o
../../Source/bmalloc/bmalloc/Gigacage.cpp: In lambda function:
../../Source/bmalloc/bmalloc/Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]
 #define GIGACAGE_RUNWAY (16llu * 1024 * 1024 * 1024)
                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
../../Source/bmalloc/bmalloc/Gigacage.cpp:159:17: note: in expansion of macro ‘GIGACAGE_RUNWAY’
             if (GIGACAGE_RUNWAY) {
                 ^~~~~~~~~~~~~~~

[Michael Catanzaro]

Created attachment 326332 [details]
Patch

[Michael Catanzaro]

Created attachment 326333 [details]
Patch

[Saam Barati]

Comment on attachment 326333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326333&action=review

> Source/bmalloc/bmalloc/Gigacage.cpp:159
> +#if !BCPU(ARM64)

Not a fan of this. Can we just make it
if (GIGACAGE_RUNWAY > 0)?

[Saam Barati]

(In reply to Saam Barati from comment #3)
> Comment on attachment 326333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326333&action=review
> 
> > Source/bmalloc/bmalloc/Gigacage.cpp:159
> > +#if !BCPU(ARM64)
> 
> Not a fan of this. Can we just make it
> if (GIGACAGE_RUNWAY > 0)?

To elaborate, this code shouldn't worry about which CPU it's on. If we decide to define GIGACAGE_RUNWAY for ARM64, we now need to change two lines of code instead of one.

[Michael Catanzaro]

(In reply to Saam Barati from comment #3) 
> Not a fan of this. Can we just make it
> if (GIGACAGE_RUNWAY > 0)?

D'oh, that's way better.

[Michael Catanzaro]

Created attachment 326339 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 326339 [details]
Patch

Clearing flags on attachment: 326339

Committed r224588: <https://trac.webkit.org/changeset/224588>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562198>