Bug 179418 – HTMLMediaElement should not use element fullscreen on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

HTMLMediaElement should not use element fullscreen on iOS

[Jeremy Jones]

rdar://problem/35409277

[Jeremy Jones]

Created attachment 326315 [details]
Patch

[Darin Adler]

Comment on attachment 326315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326315&action=review

> Source/WebCore/ChangeLog:9
> +        Add a setting videoUsesElementFullScreen to determine if HTMLMediaElement should use element full screen or not.

What’s the rationale behind using a setting instead of a compile time switch?

[Jeremy Jones]

(In reply to Darin Adler from comment #3)
> Comment on attachment 326315 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326315&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Add a setting videoUsesElementFullScreen to determine if HTMLMediaElement should use element full screen or not.
> 
> What’s the rationale behind using a setting instead of a compile time switch?

Originally I though there might be clients that wanted to control how videos were presented. But we don't actually have a use case for that. I'll change this to be a compile time switch.

[Jeremy Jones]

Created attachment 326354 [details]
Patch

[Jeremy Jones]

Created attachment 326368 [details]
Patch

[Build Bot]

Attachment 326368 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Jones]

Created attachment 326369 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 326369 [details]
Patch

Clearing flags on attachment: 326369

Committed r224607: <https://trac.webkit.org/changeset/224607>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.