Bug 179408 - [LayoutState cleanup] LayoutContext should own the stack of LayoutState objects
Summary: [LayoutState cleanup] LayoutContext should own the stack of LayoutState objects
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2017-11-07 21:06 PST by zalan
Modified: 2017-11-08 17:32 PST (History)
8 users (show)

See Also:

Patch (18.61 KB, patch)
2017-11-08 13:50 PST, zalan
koivisto: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.65 MB, application/zip)
2017-11-08 14:44 PST, Build Bot
no flags Details
Patch (18.47 KB, patch)
2017-11-08 16:16 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-11-07 21:06:53 PST
The stack (vector) reflects the functionality better.
Comment 1 Radar WebKit Bug Importer 2017-11-08 13:13:35 PST
Comment 2 zalan 2017-11-08 13:50:44 PST
Created attachment 326364 [details]
Comment 3 Antti Koivisto 2017-11-08 13:53:51 PST
Comment on attachment 326364 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=326364&action=review

> Source/WebCore/rendering/LayoutState.cpp:130
> +void LayoutState::computePaginationInformation(const LayoutContext::LayoutStateStack& layoutStateStack, RenderBox& renderer, LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged)

Please move this function out of the LayoutState at some point.
Comment 4 Build Bot 2017-11-08 14:44:26 PST
Comment on attachment 326364 [details]

Attachment 326364 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5153011

New failing tests:
Comment 5 Build Bot 2017-11-08 14:44:28 PST
Created attachment 326383 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 zalan 2017-11-08 16:16:17 PST
Created attachment 326401 [details]
Comment 7 WebKit Commit Bot 2017-11-08 17:32:21 PST
Comment on attachment 326401 [details]

Clearing flags on attachment: 326401

Committed r224612: <https://trac.webkit.org/changeset/224612>
Comment 8 WebKit Commit Bot 2017-11-08 17:32:22 PST
All reviewed patches have been landed.  Closing bug.