RESOLVED FIXED 179408
[LayoutState cleanup] LayoutContext should own the stack of LayoutState objects 
https://bugs.webkit.org/show_bug.cgi?id=179408
Summary [LayoutState cleanup] LayoutContext should own the stack of LayoutState objects
zalan
Reported 2017-11-07 21:06:53 PST
The stack (vector) reflects the functionality better.
Attachments
Patch (18.61 KB, patch)
2017-11-08 13:50 PST, zalan 		koivisto: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (2.65 MB, application/zip)
2017-11-08 14:44 PST, Build Bot 		no flags
Details
Patch (18.47 KB, patch)
2017-11-08 16:16 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-08 13:13:35 PST
<rdar://problem/35423075>
zalan
Comment 2 2017-11-08 13:50:44 PST
Created attachment 326364 [details] Patch
Antti Koivisto
Comment 3 2017-11-08 13:53:51 PST
Comment on attachment 326364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326364&action=review > Source/WebCore/rendering/LayoutState.cpp:130 > +void LayoutState::computePaginationInformation(const LayoutContext::LayoutStateStack& layoutStateStack, RenderBox& renderer, LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged) Please move this function out of the LayoutState at some point.
Build Bot
Comment 4 2017-11-08 14:44:26 PST
Comment on attachment 326364 [details] Patch Attachment 326364 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5153011 New failing tests: fast/line-grid/line-grid-into-columns.html
Build Bot
Comment 5 2017-11-08 14:44:28 PST
Created attachment 326383 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
zalan
Comment 6 2017-11-08 16:16:17 PST
Created attachment 326401 [details] Patch
WebKit Commit Bot
Comment 7 2017-11-08 17:32:21 PST
Comment on attachment 326401 [details] Patch Clearing flags on attachment: 326401 Committed r224612: <https://trac.webkit.org/changeset/224612>
WebKit Commit Bot
Comment 8 2017-11-08 17:32:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.