Bug 179406 - Disable implicit animations when adding or removing text track representation layers.
Summary: Disable implicit animations when adding or removing text track representation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-07 19:34 PST by Jeremy Jones
Modified: 2017-11-08 01:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.88 KB, patch)
2017-11-07 19:38 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-11-07 19:34:38 PST 
Disable implicit animations when adding or removing text track representation layers.
Comment 1 Jeremy Jones 2017-11-07 19:35:18 PST 
rdar://problem/34369835
Comment 2 Jeremy Jones 2017-11-07 19:38:29 PST 
Created attachment 326291 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-11-07 21:59:04 PST 
Comment on attachment 326291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326291&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1238
> +    [CATransaction begin];
> +    [CATransaction setDisableActions:YES];

Maybe we should make a stack-based class that does this.
Comment 4 WebKit Commit Bot 2017-11-08 01:49:06 PST 
Comment on attachment 326291 [details]
Patch

Clearing flags on attachment: 326291

Committed r224574: <https://trac.webkit.org/changeset/224574>
Comment 5 WebKit Commit Bot 2017-11-08 01:49:07 PST 
All reviewed patches have been landed.  Closing bug.