Bug 179390 - Add a WinCairo EWS queue
Summary: Add a WinCairo EWS queue
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2017-11-07 13:43 PST by Don Olmstead
Modified: 2017-11-15 09:40 PST (History)
6 users (show)

See Also:

Patch (5.00 KB, patch)
2017-11-07 13:47 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (5.02 KB, patch)
2017-11-07 14:04 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-11-07 13:43:21 PST
Adding a WinCairo EWS queue will help us detect build failures early
Comment 1 Don Olmstead 2017-11-07 13:47:05 PST
Created attachment 326255 [details]
Comment 2 Don Olmstead 2017-11-07 14:04:09 PST
Created attachment 326258 [details]

Fix copy paste error
Comment 3 WebKit Commit Bot 2017-11-07 14:38:37 PST
Comment on attachment 326258 [details]

Clearing flags on attachment: 326258

Committed r224549: <https://trac.webkit.org/changeset/224549>
Comment 4 WebKit Commit Bot 2017-11-07 14:38:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Aakash Jain 2017-11-07 14:42:11 PST
I will update the server to pick up the changes tonight.
Comment 6 Aakash Jain 2017-11-07 15:52:36 PST
This breaks webkitpy tests (./Tools/Scripts/test-webkitpy).

Seems like the unit-test inside config/ports_unittest.py needs some modifications related to extra arguments in the end ("--wincairo", DeprecatedPort().makeArgs()).

[53/1658] webkitpy.common.config.ports_unittest.DeprecatedPortTest.test_wincairo_port failed:                           
  Traceback (most recent call last):
    File "/Users/aakashjain/code/OpenSource/Tools/Scripts/webkitpy/common/config/ports_unittest.py", line 61, in test_wincairo_port
      self.assertEqual(WinCairoPort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wincairo"])
  AssertionError: Lists differ: ['Tools/Scripts/run-webkit-tes... != ['Tools/Scripts/run-webkit-tes...
  Second list contains 1 additional elements.
  First extra element 1:
  - ['Tools/Scripts/run-webkit-tests']
  + ['Tools/Scripts/run-webkit-tests', '--wincairo']
  ?                                  ++++++++++++++
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:40:56 PST