Bug 179383 - Add SPI function pointers qualifiers for CPU(ARM64E)
Summary: Add SPI function pointers qualifiers for CPU(ARM64E)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-07 11:42 PST by Michael Saboff
Modified: 2017-11-07 13:19 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2017-11-07 12:03 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-11-07 11:42:56 PST
Patch coming.

<rdar://problem/34780719>
Comment 1 Michael Saboff 2017-11-07 12:03:29 PST
Created attachment 326234 [details]
Patch
Comment 2 Mark Lam 2017-11-07 12:11:18 PST
Comment on attachment 326234 [details]
Patch

r=me.  Since this is a header file, I think we should prefix the #define symbols with WTF_.
Comment 3 Michael Saboff 2017-11-07 12:34:08 PST
(In reply to Mark Lam from comment #2)
> Comment on attachment 326234 [details]
> Patch
> 
> r=me.  Since this is a header file, I think we should prefix the #define
> symbols with WTF_.

Agreed.  Will do before landing.
Comment 4 Michael Saboff 2017-11-07 13:19:36 PST
Committed r224545: <https://trac.webkit.org/changeset/224545>