Bug 179380 - [LayoutState cleanup] Remove explicit LayoutStateMaintainer::pop calls.
Summary: [LayoutState cleanup] Remove explicit LayoutStateMaintainer::pop calls.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-07 11:09 PST by zalan
Modified: 2017-11-07 13:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (44.41 KB, patch)
2017-11-07 11:18 PST, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (2.19 MB, application/zip)
2017-11-07 12:14 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (3.24 MB, application/zip)
2017-11-07 13:03 PST, Build Bot 		no flags Details
Patch (47.36 KB, patch)
2017-11-07 13:04 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-11-07 11:09:32 PST 
and move it to the LayoutStateMaintainer d'tor
Comment 1 Radar WebKit Bug Importer 2017-11-07 11:10:52 PST 
<rdar://problem/35392161>
Comment 2 zalan 2017-11-07 11:18:54 PST 
Created attachment 326224 [details]
Patch
Comment 3 Antti Koivisto 2017-11-07 11:55:47 PST 
Comment on attachment 326224 [details]
Patch

r=me
Comment 4 Build Bot 2017-11-07 12:14:45 PST 
Comment on attachment 326224 [details]
Patch

Attachment 326224 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5136984

New failing tests:
fast/repaint/align-items-change.html
Comment 5 Build Bot 2017-11-07 12:14:46 PST 
Created attachment 326236 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-11-07 13:03:13 PST 
Comment on attachment 326224 [details]
Patch

Attachment 326224 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5137143

New failing tests:
fast/repaint/align-items-change.html
Comment 7 Build Bot 2017-11-07 13:03:14 PST 
Created attachment 326246 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 zalan 2017-11-07 13:04:00 PST 
Created attachment 326247 [details]
Patch
Comment 9 WebKit Commit Bot 2017-11-07 13:36:11 PST 
Comment on attachment 326247 [details]
Patch

Clearing flags on attachment: 326247

Committed r224546: <https://trac.webkit.org/changeset/224546>
Comment 10 WebKit Commit Bot 2017-11-07 13:36:12 PST 
All reviewed patches have been landed.  Closing bug.