Bug 179365 – REGRESSION(r223773): [GTK] WebKitWebInspector bring-to-front signal is emitted right after open-window

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

In the GTK+ API, open-window already implies presenting the window to bring it to the front, so it's not expected that bring-to-front is emitted on open. This is happening since r223773 that moved common code from platform specific inspector files to the main file, but in the case of open the mac implementation was not exactly the same as the GTK+ one. This broke /webkit2/WebKitWebInspector/default and /webkit2/WebKitWebInspector/manual-attach-detach.

[Carlos Garcia Campos]

Created attachment 326198 [details]
Patch

I'm not happy adding a platform ifdef to WebInspectorProxy.cpp after a refactoring to share code, but in this case I don't see a better way. Going back to platformOpen() when only one line differs is not better.

[Michael Catanzaro]

Comment on attachment 326198 [details]
Patch

OK, unless Brian or Joe want to take a different approach.

[Blaze Burg]

Comment on attachment 326198 [details]
Patch

If there is some way to check this inside platformBringToFront() and do nothing in this case, that would be better. Having a platform guard around a virtual platform method seems nonsensical.

[Carlos Garcia Campos]

(In reply to Brian Burg from comment #3)
> Comment on attachment 326198 [details]
> Patch
> 
> If there is some way to check this inside platformBringToFront() and do
> nothing in this case, that would be better. Having a platform guard around a
> virtual platform method seems nonsensical.

Yes I can add a m_isOpening and check it from GTK specific impl, I discarded that because it's adding a member just for that and only used by GTK+.

[Carlos Garcia Campos]

Created attachment 326309 [details]
Patch for landing

Removed the platform ifdef in cross-platform file.

[Carlos Garcia Campos]

Committed r224575: <https://trac.webkit.org/changeset/224575>