Bug 179360 – Web Inspector: Create inspector agents lazily

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Create inspector agents lazily

Move some agents to be created lazily. We don't need these to be created along with the WebCore::Page since they are only needed when an inspector frontend connects.

Our goal should be to move more and more of these to be lazily created.

[Joseph Pecoraro]

Created attachment 326186 [details]
[PATCH] Proposed Fix

[Build Bot]

Attachment 326186 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorController.cpp:154:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 326186 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326186&action=review

> Source/WebCore/inspector/InspectorController.cpp:153
> -        commandLineAPIHost->init(m_inspectorAgent
> +        commandLineAPIHost->init(

I can make this all one line now. It used to be split up because of ENABLE guards that no longer exist.

[WebKit Commit Bot]

Comment on attachment 326186 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 326186

Committed r224530: <https://trac.webkit.org/changeset/224530>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567071>