Bug 179349 - Only build ImageDiff for mac
Summary: Only build ImageDiff for mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-06 16:01 PST by Jonathan Bedard
Modified: 2017-11-06 16:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.11 KB, patch)
2017-11-06 16:12 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-11-06 16:01:47 PST 
ImageDiff should usually be built for the platform of the machine doing the building, not the target SDK.
Comment 1 Radar WebKit Bug Importer 2017-11-06 16:04:03 PST 
<rdar://problem/35376244>
Comment 2 Radar WebKit Bug Importer 2017-11-06 16:04:32 PST 
<rdar://problem/35376237>
Comment 3 Jonathan Bedard 2017-11-06 16:12:32 PST 
Created attachment 326166 [details]
Patch
Comment 4 WebKit Commit Bot 2017-11-06 16:48:44 PST 
Comment on attachment 326166 [details]
Patch

Clearing flags on attachment: 326166

Committed r224518: <https://trac.webkit.org/changeset/224518>
Comment 5 WebKit Commit Bot 2017-11-06 16:48:46 PST 
All reviewed patches have been landed.  Closing bug.