Bug 179346 - Web Inspector: Canvas Tab: canvas card selection not restored on page reload
Summary: Web Inspector: Canvas Tab: canvas card selection not restored on page reload
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://acko.net
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasTab
  Show dependency tree / graph
 
Reported: 2017-11-06 15:21 PST by Brian Burg
Modified: 2018-08-28 11:46 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-11-06 15:21:31 PST 
Steps to reproduce:
0. Load acko.net, see three canvas cards in Canvas Tab
1. Make card selection
2. Reload page
=> Selection is lost, despite canvases being recreated within the cookie restoration last chance timeout
Comment 1 Radar WebKit Bug Importer 2017-11-06 15:21:53 PST 
<rdar://problem/35375222>
Comment 2 Devin Rousso 2017-11-06 16:06:38 PST 
Do we have a reliable method of "identifying" canvas contexts?  As an example, <http://acko.net> uses additional canvases for feature detection.  These canvases are sometimes GC'd before I can see them in the UI (leaving 1 canvas showing).  If I select this canvas and refresh, and on the next load the other canvases are not GC'd as fast, which canvas should be selected?  Should it be by index (meaning the first canvas is selected, regardless of what it is), or should we go by DOM path (but then what about double/triple buffer canvases)?  I agree that we should have some selection restoration, but I am not sure how to go about it for some of these edge cases.  Admittedly, most pages do only have 1 or 2 canvases ¯\_(ツ)_/¯
Comment 3 Devin Rousso 2018-08-28 11:46:22 PDT 
Canvases are no longer selectable in the Overview.