Bug 179328 - Web Inspector: no way to navigate from Resource tree element to its entry in Network Tab
Summary: Web Inspector: no way to navigate from Resource tree element to its entry in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-06 10:20 PST by BJ Burg
Modified: 2017-11-06 13:08 PST (History)
4 users (show)

See Also:


Attachments
[IMAGE] DOM Tree - Reveal in Network (181.78 KB, image/png)
2017-11-06 12:09 PST, Joseph Pecoraro
no flags Details
[IMAGE] Resource Sidebar - Reveal in Network (58.83 KB, image/png)
2017-11-06 12:09 PST, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (10.75 KB, patch)
2017-11-06 12:09 PST, Joseph Pecoraro
bburg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-11-06 10:20:31 PST
This should be offered as a context menu option if we saw the load of this resource. If there's nothing available, then show the context menu item but gray it out.
Comment 1 Radar WebKit Bug Importer 2017-11-06 10:20:53 PST
<rdar://problem/35367294>
Comment 2 Joseph Pecoraro 2017-11-06 12:05:04 PST
We should support any URL, just like we do in other places.
Comment 3 Joseph Pecoraro 2017-11-06 12:09:04 PST
Created attachment 326145 [details]
[IMAGE] DOM Tree - Reveal in Network
Comment 4 Joseph Pecoraro 2017-11-06 12:09:21 PST
Created attachment 326146 [details]
[IMAGE] Resource Sidebar - Reveal in Network
Comment 5 Joseph Pecoraro 2017-11-06 12:09:37 PST
Created attachment 326147 [details]
[PATCH] Proposed Fix
Comment 6 BJ Burg 2017-11-06 12:23:47 PST
Comment on attachment 326147 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326147&action=review

r=me

> Source/WebInspectorUI/ChangeLog:29
> +        Make use of new ContentMenu utility to add menu items for a URL.

Nit: ContextMenu

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:98
> +    contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {

I always find this UIString confusing, because it doesn't explicitly say Browser Tab. And then I do it and nothing appears in Web Inspector tab. When windowed, it looks like it's just broken.
Comment 7 Joseph Pecoraro 2017-11-06 13:08:25 PST
<https://trac.webkit.org/r224508>