Canonical name of EUC-KR encoding should be EUC-KR, not windows-949
Created attachment 326088 [details] Patch
Comment on attachment 326088 [details] Patch Attachment 326088 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5117169 New failing tests: fast/encoding/char-decoding.html
Created attachment 326089 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326088 [details] Patch Attachment 326088 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5117177 New failing tests: fast/encoding/char-decoding.html
Comment on attachment 326088 [details] Patch Attachment 326088 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5117139 New failing tests: fast/encoding/char-decoding.html
Created attachment 326090 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 326091 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Turns out that this actually makes a functional difference to decoding, since ICU does not believe EUC-KR and windows-949 are the same, thus the fast/encoding/char-decoding.html failures. Web Platform sets does not appear to have a test that can tell the difference. Chrome and Firefox both treat EUC-KR as the canonical name but decode as if windows-949. They also both do not seem to recognize x-windows-949.
Comment on attachment 326088 [details] Patch Attachment 326088 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5117199 New failing tests: fast/encoding/char-decoding.html http/tests/workers/service/service-worker-clear.html
Created attachment 326092 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 326095 [details] Patch
Comment on attachment 326095 [details] Patch Rejecting attachment 326095 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 326095, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ayoutTests/imported/w3c/ChangeLog error: Error building trees Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog error: Error building trees Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/5119591
Created attachment 326108 [details] Patch for landing
Comment on attachment 326108 [details] Patch for landing Clearing flags on attachment: 326108 Committed r224484: <https://trac.webkit.org/changeset/224484>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35567086>